[www] Gatsby/rebeccapurple banner #6161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fk
commented
Jun 26, 2018
fk
commented
- Reduce banner font-size.
- Store banner height in presets.bannerHeight.
- Reduce banner copy from „You're viewing the docs for Gatsby v2 beta. View the v1 docs instead.“ to „These are the docs for v2 beta. View the v1 docs instead.“ and drop the „instead“ for screens < presets.Mobile. This change makes the banner copy fit in one (instead of two) lines on screens with a maximum width of 320px.
- Remove sidebar inset box-shadow.
* Reduce banner font-size. * Store banner height in presets.bannerHeight. * Reduce banner copy from „You're viewing the docs for Gatsby v2 beta. View the v1 docs instead.“ to „These are the docs for v2 beta. View the v1 docs instead.“ and drop the „instead“ for screens < presets.Mobile. This change makes the banner copy fit in one (instead of two) lines on screens with a maximum width of 320px. * Remove sidebar inset box-shadow.
|
Ah, hold on—let me fix the banner overlapping the main navigation:
|
|
GTG:
|
|
Deploy preview for gatsbygram ready! Built with commit 59b0979 |
|
Deploy preview for using-drupal ready! Built with commit 59b0979 |
|
Deploy preview for using-drupal ready! Built with commit c130283 |
|
Deploy preview for gatsbygram ready! Built with commit c130283 |
|
PS: This PR is powered by the 90s: https://www.youtube.com/watch?v=BWTJ2st1PpQ :-D |
m-allanson
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.