[WIP][www] Sidebars à la reactjs.org (accordions, scrollspy) #6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ports sidebar navigation accordions and „scroll spy“ behavior from the ReactJS docs, with a few adjustments: * closely stick to the current `yml` format * instead of mixing user-defined `id` and `href` values, stick to the existing `link` * opt in to setting a „directory“ (think „baseUrl“ for all item links in `yml`) — makes * generate an `id` for every `yaml` navigation item (as opposed to I had to bump gatsby-remark-prismjs from 1.2.23 to 2.0.4 after I — all of a sudden — ran into the `Uncaught TypeError: Cannot read property 'tokenizePlaceholders' of undefined` error.
|
Hey! Sorry to do this to you but we're not making any more substantive changes to v1 version of gatsbyjs.org — this branch should mostly merge cleanly into master so could you do that and create a new PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, has some issues with properly highlighting some active menu items in "Tutorial" due to some last-minute changes. Will fix and provide more detail here tomorrow.
This ports sidebar navigation accordions and „scroll spy“ behavior from the ReactJS docs, with a few adjustments:
ymlformatidandhrefvalues, stick to the existinglinkyml) — makesidfor everyyamlnavigation itemI had to bump gatsby-remark-prismjs from 1.2.23 to 2.0.4 after I — all of a sudden — ran into the
Uncaught TypeError: Cannot read property 'tokenizePlaceholders' of undefinederror.