fix for "external" PageRenderer not working in production #5986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for gatsbygram ready! Built with commit 13be14f |
|
Deploy preview for using-drupal ready! Built with commit 13be14f |
…epending on NODE_ENV
pieh
force-pushed
the
v2-exported-page-render-prod
branch
from
78a302f to
f75fe16
Compare
pieh
force-pushed
the
v2-exported-page-render-prod
branch
from
c342341 to
13be14f
Compare
|
This can be reviewed now. Here's example of this working in production - https://deploy-preview-5986--gatsbyjs.netlify.com/showcase (click on any site - dimmed showcase listing should stay in background) |
m-allanson
approved these changes
Jun 22, 2018
|
Yeah, right now we don't use JSONStore in production code and I think it's desireable. We probably could remove those checks in component itself so code is more readable and maybe add check outside of component to exit build if we are using JSONStore in production |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this also allow to not bundle "./pages.json" in entry point production bundle and to not bundle JSONStore in production
closes #5920