New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] Pass actions to onCreateWebpackConfig #5522

Closed

jaredpalmer wants to merge 1 commit into gatsbyjs:v2 from jaredpalmer:patch-1

jaredpalmer commented May 22, 2018 •

edited

Loading

No description provided.


          [v2] Pass actions to onCreateWebpackConfig

f869f25

Author

jaredpalmer commented May 22, 2018

This actually doesn't fix #5520, but was my first guess.

jaredpalmer closed this

jaredpalmer reopened this

Author

jaredpalmer commented May 23, 2018

This actually does fix the problem.

mquandalle mentioned this pull request

[v2] Typescript plugin not working #5520

Closed

Contributor

jquense commented May 24, 2018

this is a bit confusing since actions are passed automatically to all api calls: https://github.com/jaredpalmer/gatsby/blob/f869f250d9e194d9567b68ef401cebf192303581/packages/gatsby/src/utils/api-runner-node.js#L76 is something overloaded?

Contributor

jquense commented May 24, 2018

hmm and it already works elsewhere...https://github.com/gatsbyjs/gatsby/blob/v2/packages/gatsby-plugin-less/src/gatsby-node.js

Contributor

KyleAMathews commented May 25, 2018

Yeah — this PR doesn't seem like the right fix — @jaredpalmer could you double check what keys are on the initial object parameter?

Author

jaredpalmer commented May 25, 2018

Yeah i don't thin this is the issue. Closing

jaredpalmer closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet