gatsby-plugin-manifest: manifest file path #4901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsby-plugin-manifest writes manifest file into the './public/icons' directory, where favicons are placed themselfs. According to specification how src member is being handled: https://www.w3.org/TR/appmanifest/#dom-imageresource-src > The algorithm takes a ImageResource icon, and a URL manifest URL, > which is the URL from which the manifest was fetched. manifest URL is used as base-URL and during the URL processing it exposes in the wrong way. You can reproduce it in your browser console. new URL( 'icons/some_icon.png', 'http://localhost/icons/manifest.json' ); > URL { > href: "http://localhost/icons/icons/some_icon.png", > ... > } For more info about URL parsing please take a look at specification: https://url.spec.whatwg.org/#concept-url-parser repoduced in: - Firefox Quantum 59.0.2; - Chromium Version 64.0.3282.119;
|
Deploy preview for using-drupal ready! Built with commit b26a4bc |
|
Deploy preview for gatsbygram ready! Built with commit b26a4bc |
|
Thanks for PR! This is actually pretty much duplicate of #4890 which already was reviewed and is close to be merged, so I'll close this for now. |
|
oops, missed that х) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gatsby-plugin-manifest writes manifest file into the
'./public/icons' directory, where favicons are placed
themselfs.
According to specification how src member is being handled:
https://www.w3.org/TR/appmanifest/#dom-imageresource-src
manifest URL is used as base-URL and during the URL processing
it exposes in the wrong way.
You can reproduce it in your browser console.
For more info about URL parsing please take a look at specification:
https://url.spec.whatwg.org/#concept-url-parser
repoduced in: