-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Gatsby Image more configurable #4105
Conversation
Added a new prop `imgStyle` which is now spread into default styles of img element.
Deploy preview for gatsbygram ready! Built with commit 240a77c |
Hey awesome work! Nice refactor + feature improvement. It does seem to have broken a few images in using-gatsby-image for reasons I'm not quite sure of — https://deploy-preview-4105--using-gatsby-image.netlify.com/blur-up/ |
@KyleAMathews thanks! But I don't see any broken images on https://deploy-preview-4105--using-gatsby-image.netlify.com/blur-up/ - I tested this example site locally and it worked fine too. Can you check again? Anything in the console? |
This got added by mistake during refactor. We originally had transitionDelay only for image placeholders. Removing this from actual image style now.
Well, pushed in a minor change but it shouldn't have been the cause of this issue. I could not reproduce the issue either locally or in the preview build on both Chrome 64 & Firefox 58 on Ubuntu. Wonder if this could be an issue with specific browser/version with |
…atsby-image-props
@KyleAMathews do you see the error consistently? If it's a Netlify error, I should also be getting it I guess. Wonder if others are able to see the bug? @m-allanson could you check if the deploy preview works for you? |
I've never seen it before actually so not sure what it is or means. Just checked the same page again and now it's working 🤷♂️ |
Thanks for the PR! |
Thank you @tsriram!! |
Closes #3561