Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Gatsby Image more configurable #4105

Merged
merged 8 commits into from
Feb 19, 2018

Conversation

tsriram
Copy link
Contributor

@tsriram tsriram commented Feb 17, 2018

Closes #3561

@ghost ghost assigned tsriram Feb 17, 2018
@ghost ghost added the review label Feb 17, 2018
@gatsbybot
Copy link
Collaborator

gatsbybot commented Feb 17, 2018

Deploy preview for gatsbygram ready!

Built with commit 240a77c

https://deploy-preview-4105--gatsbygram.netlify.com

@ghost ghost assigned KyleAMathews Feb 17, 2018
@KyleAMathews
Copy link
Contributor

Hey awesome work! Nice refactor + feature improvement.

It does seem to have broken a few images in using-gatsby-image for reasons I'm not quite sure of — https://deploy-preview-4105--using-gatsby-image.netlify.com/blur-up/

@tsriram
Copy link
Contributor Author

tsriram commented Feb 17, 2018

@KyleAMathews thanks! But I don't see any broken images on https://deploy-preview-4105--using-gatsby-image.netlify.com/blur-up/ - I tested this example site locally and it worked fine too. Can you check again? Anything in the console?

@KyleAMathews
Copy link
Contributor

The top image never loads

screen shot 2018-02-17 at 9 53 11 am

@tsriram
Copy link
Contributor Author

tsriram commented Feb 17, 2018

Ah, another "works on my machine" moment! But this looks weird. Let me take a detailed look.

image

This got added by mistake during refactor. We originally had transitionDelay only for image placeholders. Removing this from actual image style now.
@tsriram
Copy link
Contributor Author

tsriram commented Feb 18, 2018

Well, pushed in a minor change but it shouldn't have been the cause of this issue. I could not reproduce the issue either locally or in the preview build on both Chrome 64 & Firefox 58 on Ubuntu. Wonder if this could be an issue with specific browser/version with IntersectionObserver?

@KyleAMathews
Copy link
Contributor

Hmmm could just be a Netify error actually

screen shot 2018-02-17 at 10 26 46 pm

@tsriram
Copy link
Contributor Author

tsriram commented Feb 19, 2018

@KyleAMathews do you see the error consistently? If it's a Netlify error, I should also be getting it I guess. Wonder if others are able to see the bug? @m-allanson could you check if the deploy preview works for you?

@KyleAMathews
Copy link
Contributor

I've never seen it before actually so not sure what it is or means. Just checked the same page again and now it's working 🤷‍♂️

@KyleAMathews KyleAMathews merged commit 93c4ddc into gatsbyjs:master Feb 19, 2018
@ghost ghost removed the review label Feb 19, 2018
@KyleAMathews
Copy link
Contributor

Thanks for the PR!

@fk
Copy link
Contributor

fk commented Feb 21, 2018

Thank you @tsriram!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants