Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(webpack loaders) manage images links with query parameters #398

Merged
merged 1 commit into from
Aug 18, 2016
Merged

(webpack loaders) manage images links with query parameters #398

merged 1 commit into from
Aug 18, 2016

Conversation

tsunammis
Copy link
Contributor

When a image link contains query parameter, webpack doesn't
handle it.

e.g. with a link to an .svg file -> .../file.svg?v=1

the file will not be handle by webpack, and the user will get
an error like below.

Module parse failed:
/.../node_modules/font-awesome/fonts/fontawesome-webfont.svg?v=4.6.3
Unexpected token (1:0)
You may need an appropriate loader to handle this file type.

When a image link contains query parameter, webpack doesn't
handle it.

e.g. with a link to an .svg file -> .../file.svg?v=1

the file will not be handle by webpack, and the user will get
an error like below.

```
Module parse failed:
/.../node_modules/font-awesome/fonts/fontawesome-webfont.svg?v=4.6.3
Unexpected token (1:0)
You may need an appropriate loader to handle this file type.
```
@KyleAMathews
Copy link
Contributor

Oh cool! Thanks! Unless someone sees a problem with this, I'll merge it later. Seems like a reasonable tweak.

@tsunammis
Copy link
Contributor Author

@KyleAMathews Thanks you.

It is related to the same issue on create-react-app-> facebook/create-react-app#298

@KyleAMathews
Copy link
Contributor

Haha "Create React App" peeps are the Webpack DX prototypers of the internet ❤️

@KyleAMathews KyleAMathews merged commit 1181313 into gatsbyjs:master Aug 18, 2016
@tsunammis
Copy link
Contributor Author

Thanks, could you bump the version ? :)

@KyleAMathews
Copy link
Contributor

Waiting for tests to finish on #399

@tsunammis
Copy link
Contributor Author

@KyleAMathews Ok ;-) great.

@KyleAMathews
Copy link
Contributor

0.12.4 is out

@jlengstorf
Copy link
Contributor

Hiya @tsunammis! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants