Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update e2e-tests to v8 [security] #39090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 19, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@simonsmith/cypress-image-snapshot ^6.1.1 -> ^8.0.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-38695

Impact

It's possible for a user to pass a relative file path for the snapshot name and reach outside of the project directory into the machine running the test. Example:

  cy.get('h1').matchImageSnapshot('../../../ignore-relative-dirs')

The above will create an ignore-relative-dirs.png three levels up

Patches

Fixed in 8.0.2

Workarounds

Validate all the existing uses of matchImageSnapshot to ensure correct use of the filename argument. Example:

    // snapshot name will be the test title
    cy.matchImageSnapshot();

    // snapshot name will be the name passed in
    cy.matchImageSnapshot('login');

References

https://github.com/simonsmith/cypress-image-snapshot/issues/15


Release Notes

simonsmith/cypress-image-snapshot (@​simonsmith/cypress-image-snapshot)

v8.0.2

Compare Source

Bug Fixes

v8.0.1

Compare Source

Bug Fixes
  • rename e2eSpecFolder -> e2eSpecDir (106af6c)

v8.0.0

Compare Source

Bug Fixes
  • requireSnapshots should work with retries (ebfc8be)
Features
  • normalise directory output for snapshots (1939e25)
BREAKING CHANGES
  • This uses the Cypress.spec.relative option to
    generate the snapshot directory and changes the folder structure.

It should now match the directory structure found in the cypress/e2e/
directory

Updating to this change may mean committing new snapshot paths and
removing old ones in your project (especially with component testing)

See the section "Snapshot paths" in the README for more information

v7.0.0

Compare Source

Bug Fixes
Features
  • add recording of snapshot result (488ae4b)
  • add semantic release (b1b063b)
  • allow default options to be passed into addMatchImageSnapshotCommand (405afcb)
BREAKING CHANGES
  • removed fork of original package

This is a rewrite of the original library, now with full support for
TypeScript and improved testing.

Notes:

  • The API for matchImageSnapshot remains the same, as well as all the
    import paths
  • The behavior of the plugin is exactly the same, as are the default
    options

TypeScript types are exported under @simonsmith/cypress-image-snapshot/types.
These should be used instead of the package on DefinitelyTyped

Removed:

  • The reporter is not supported in this version.

Configuration

📅 Schedule: Branch creation - "" in timezone GMT, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot label Sep 19, 2024
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 19, 2024
@renovate renovate bot force-pushed the renovate/npm-simonsmith-cypress-image-snapshot-vulnerability branch 9 times, most recently from 135808f to c59e3ee Compare September 23, 2024 23:13
@renovate renovate bot force-pushed the renovate/npm-simonsmith-cypress-image-snapshot-vulnerability branch from c59e3ee to e920315 Compare September 27, 2024 22:42
@renovate renovate bot changed the title fix(deps): update e2e-tests to v8 [security] fix(deps): update e2e-tests to v9 [security] Sep 27, 2024
@renovate renovate bot force-pushed the renovate/npm-simonsmith-cypress-image-snapshot-vulnerability branch from e920315 to e273e9c Compare September 27, 2024 22:47
@renovate renovate bot changed the title fix(deps): update e2e-tests to v9 [security] fix(deps): update e2e-tests to v8 [security] Sep 27, 2024
@renovate renovate bot force-pushed the renovate/npm-simonsmith-cypress-image-snapshot-vulnerability branch from e273e9c to ee36adc Compare October 1, 2024 22:38
@renovate renovate bot changed the title fix(deps): update e2e-tests to v8 [security] fix(deps): update e2e-tests to v9 [security] Oct 1, 2024
@renovate renovate bot force-pushed the renovate/npm-simonsmith-cypress-image-snapshot-vulnerability branch from ee36adc to daee163 Compare October 1, 2024 22:42
@renovate renovate bot changed the title fix(deps): update e2e-tests to v9 [security] fix(deps): update e2e-tests to v8 [security] Oct 1, 2024
@renovate renovate bot force-pushed the renovate/npm-simonsmith-cypress-image-snapshot-vulnerability branch from daee163 to d271f6b Compare October 3, 2024 23:50
@renovate renovate bot changed the title fix(deps): update e2e-tests to v8 [security] fix(deps): update e2e-tests to v9 [security] Oct 3, 2024
@renovate renovate bot force-pushed the renovate/npm-simonsmith-cypress-image-snapshot-vulnerability branch from d271f6b to 920b5cc Compare October 4, 2024 01:08
@renovate renovate bot changed the title fix(deps): update e2e-tests to v9 [security] fix(deps): update e2e-tests to v8 [security] Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants