fix(contentful): rich text linked asset filter #38716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
|
CC @axe312ger in case you don't get a notification. |
pieh
added
topic: source-contentful
|
Thank you. At some point, this will be annoying when supporting multi-space assets and references, but this will not be the only position in code where we have to adjust. Therefore, I merge it now. Thanks! |
axe312ger
merged commit 9e61200
into
gatsbyjs:feat/contentful-schema-generation
31 of 33 checks passed
|
Released as gatsby-source-contentful@9.0.0-alpha.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in the gatsby-source-contentful major version thread (#38585 (reply in thread)), there is a tiny little bug in the rich text linked asset query. The Gatsby GraphQL Node Model method
findAllrequires the query params to be wrapped in afilterobject.Documentation
See the findAll docs here.
Tests
I did not add tests for the fix. Let me know if I should!