-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby,gatsby-adapter-netlify): support pathPrefix and trailingSlash options #38666
Merged
pieh
merged 34 commits into
master
from
feat/netlify-adapter-support-trailing-slash-path-prefix
Nov 13, 2023
Merged
feat(gatsby,gatsby-adapter-netlify): support pathPrefix and trailingSlash options #38666
pieh
merged 34 commits into
master
from
feat/netlify-adapter-support-trailing-slash-path-prefix
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-support-trailing-slash-path-prefix
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Oct 25, 2023
pieh
added
topic: adapters
Related to Gatsby Adapters
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Oct 25, 2023
…r-support-trailing-slash-path-prefix
This was referenced Dec 22, 2023
This was referenced Dec 29, 2023
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for
pathPrefix
and alltrailingSlash
options togatsby-adapter-netlify
.On the adapter side:
pathPrefix
and alltrailingSlash
options/prefix/page/
- then .html asset should bepublic/prefix/page/index.html
/prefix/page
- then .html asset should bepublic/prefix/page.html
.cache
andpublic
locally (gatsby doesn't handle file moves and it expects artificats in same place, so we cache state ofpublic
before we do file moves, so when we restore it on future build assets are in places expected by gatsby)There are some adjustments on Gatsby side as well:
Tests
e2e-adapters in this PR start running 2 variants:
always
)never
trailing slashVarious assertions and test setup were adjusted so same tests can be used for both variants (they will adjust their assertions based on variant settings).
Additionally this unskips the e2e tests for trailing slash behavior (and we test both
always
andnever
variants)Related Issues
FRA-65
FRA-23