chore(docs): Adapters #38233
Merged
chore(docs): Adapters #38233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
added
the
type: documentation
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
codebyuma
reviewed
Jun 16, 2023
There was a problem hiding this comment.
Hi @LekoArts, I just finished my first review. There is a lot of great content here! For the most part, it's easy to follow and I thought the examples were really helpful.
I left a number of suggestions for your consideration - mostly around grammar or to make something a bit clearer. I also left a few questions for you and one or two suggestions for adding links or information in other places.
Hopefully the suggestions are clear but I'm happy to jump on a call to discuss or pair if needed, just let me know.
docs/docs/how-to/previews-deploys-hosting/zero-configuration-deployments.md
Outdated
Show resolved
Hide resolved
docs/docs/how-to/previews-deploys-hosting/creating-an-adapter.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Uma Chandran <codebyuma@users.noreply.github.com>
Co-authored-by: Uma Chandran <codebyuma@users.noreply.github.com>
X-oss-byte
approved these changes
Jun 30, 2023
X-oss-byte
approved these changes
Jun 30, 2023
X-oss-byte
approved these changes
Jun 30, 2023
pieh
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RFC: #38231
Docs changes for feature PR: #38232
Sidebar PR: https://github.com/gatsby-inc/dotcom/pull/846
Related Issues
#38232