Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): move typing for enableStatefulSourceNodes into Actions #37933

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix(gatsby): move typing for enableStatefulSourceNodes into Actions #37933

merged 1 commit into from
Apr 12, 2023

Conversation

axe312ger
Copy link
Collaborator

While merging master into #30855, I found out that the type definition of enableStatefulSourceNodes is at the wrong position.

My typescript is now happy with the change :)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 12, 2023
@LekoArts LekoArts added topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 12, 2023
LekoArts
LekoArts approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @pieh noted this in #37920 (comment) 👍

@LekoArts LekoArts changed the title fix: move typing for enableStatefulSourceNodes into Actions fix(gatsby): move typing for enableStatefulSourceNodes into Actions Apr 12, 2023
@LekoArts LekoArts merged commit ba2a45f into master Apr 12, 2023
@LekoArts LekoArts deleted the fix/type-enableStatefulSourceNodes branch April 12, 2023 08:57
@pieh pieh mentioned this pull request Apr 12, 2023
Merged
@0xSebin 0xSebin mentioned this pull request Jun 8, 2023
Open
@monizb monizb mentioned this pull request Jun 8, 2023
Open
@0xSebin 0xSebin mentioned this pull request Jun 8, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jun 8, 2023
Open
@monizb monizb mentioned this pull request Jun 8, 2023
Open
@0xSebin 0xSebin mentioned this pull request Jun 9, 2023
Open
This was referenced Jun 9, 2023
Open
Open
@0xSebin 0xSebin mentioned this pull request Jun 9, 2023
Open
@monizb monizb mentioned this pull request Jun 9, 2023
Open
This was referenced May 13, 2024
Open
Open
This was referenced May 13, 2024
Open
Open
Open
Open
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request May 14, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

@TylerBarnes TylerBarnes Awaiting requested review from TylerBarnes

Assignees
No one assigned
Labels
topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axe312ger @LekoArts