fix(gatsby-plugin-sitemap): remove splice for default filter #37916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
kathmbeck
removed
the
status: triage needed
LekoArts
added
the
topic: plugins
LekoArts
suggested changes
Apr 6, 2023
There was a problem hiding this comment.
Please add tests to https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-plugin-sitemap/src/__tests__/internals.js to verify this behavior
kathmbeck
force-pushed
the
remove-splice-default
branch
from
379a41e
to
341cd53
Compare
LekoArts
approved these changes
Apr 12, 2023
This was referenced Jun 9, 2023
This was referenced May 13, 2024
This was referenced May 13, 2024
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing the defaults from the array appears to re-introduce the paths to the sitemap on incremental builds.
Documentation
Tests
Related Issues