fix(gatsby): Pass pluginName
to reporter.activityTimer
& reporter.createProgress
#37710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when using
activityTimer
inside a plugin and then calling.panicOnBuild
on that activity, thepluginName
is not passed.Therefore the custom error from
setErrorMap
can't be found (becausepluginName
is required).This fixes it by optionally passing
pluginName
toactivityTimer
&createProgress
so thatpanic
andpanicOnBuild
methods on them can work correctly.Tests
Updated the
api-runner-node
testsRelated Issues
Found this while working on #37538