CTF-next: rewrite to TypeScript #37123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: source-contentful
17 tasks
…-schema-generation-typescript
…-schema-generation-typescript
b-vb
reviewed
Mar 9, 2023
| "build": "babel src --out-dir . --ignore **/__tests__ --ignore **/__fixtures__", | ||
| "prepare": "cross-env NODE_ENV=production npm run build", | ||
| "watch": "babel -w src --out-dir . --ignore **/__tests__ --ignore **/__fixtures__" | ||
| "build": "babel src --out-dir dist/ --ignore \"**/__tests__\" --ignore \"**/__mocks__\" --extensions \".ts,.js\"", |
There was a problem hiding this comment.
I might be missing something, but what's the reason for building the plugin? Is it needed for Gatsby projects that aren't compiling TypeScript yet?
There was a problem hiding this comment.
Nope, it is because plugins need to be provided in JS.
| @@ -1,8 +1,8 @@ | |||
| { | |||
| "name": "gatsby-source-contentful", | |||
| "description": "Gatsby source plugin for building websites using the Contentful CMS as a data source", | |||
| "version": "8.8.0-next.0", | |||
There was a problem hiding this comment.
yes, the projects repository automation will take care of versioning :)
Comment on lines
261
to
262
| // _context: any, | ||
| // _info: GraphQLResolveInfo, |
LekoArts
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the plugin code base to TS.
Will eventually increase reliability and developer experience.
Also, as we have a detailed, big, code review upcoming with the next version. Doing this now allows us to review the TS port at the same time.
This turns #30855 into TypeScript