Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctf-next: use link extension instead of adding ___NODE to field names #37021

Conversation

axe312ger
Copy link
Collaborator

see #30855

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 11, 2022
@axe312ger axe312ger marked this pull request as draft November 11, 2022 15:01
@LekoArts LekoArts added topic: source-contentful Related to Gatsby's integration with Contentful and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 14, 2022
@axe312ger axe312ger self-assigned this Nov 14, 2022
@axe312ger axe312ger marked this pull request as ready for review November 14, 2022 16:15
const referenceFields = [
...referenceFieldMap.get(n.sys.contentType),
...reverseReferenceFields,
]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field name merge could happen earlier, but will be rewritten anyways very soon due to planned structural changes in the (automatic) reverse links

@axe312ger axe312ger merged commit 684a13d into feat/contentful-schema-generation Nov 17, 2022
@axe312ger axe312ger deleted the refactor/ctf-next-migrate-to-link-extension branch November 17, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants