Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Expose serverDataStatus field in SSR type declaration file #35505

Merged
merged 3 commits into from
May 5, 2022
Merged

chore(gatsby): Expose serverDataStatus field in SSR type declaration file #35505

merged 3 commits into from
May 5, 2022

Conversation

chrisq21
Copy link
Contributor

Description

This PR adds the serverDataStatus property to the ISSRData type in page-ssr/index.d.ts.

I'm currently working on a PR in the netlify-plugin-gatsby repo that allows the use of custom status codes in SSR & DSG responses. Doing so requires accessing the serverDataStatus property on the ISSRData object.

Related Issues

  • None

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 27, 2022
@LekoArts LekoArts changed the title Expose serverDataStatus field in SSR type declaration file chore(gatsby): Expose serverDataStatus field in SSR type declaration file May 5, 2022
@LekoArts LekoArts added topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 5, 2022
LekoArts
LekoArts approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that this can change at any time though

@LekoArts LekoArts merged commit 39e9840 into gatsbyjs:master May 5, 2022
@snyk-bot snyk-bot mentioned this pull request May 10, 2022
Open
@Rutam21 Rutam21 mentioned this pull request May 10, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request May 10, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 10, 2022
Open
@kaocher82 kaocher82 mentioned this pull request May 10, 2022
Open
@Rutam21 Rutam21 mentioned this pull request May 10, 2022
Open
@0xSebin 0xSebin mentioned this pull request May 10, 2022
Open
@ajesse11x ajesse11x mentioned this pull request May 10, 2022
Open
@0xSebin 0xSebin mentioned this pull request May 10, 2022
Open
@saurabharch saurabharch mentioned this pull request May 10, 2022
Open
This was referenced May 10, 2022
Open
Open
Open
Open
@nidhi42 nidhi42 mentioned this pull request May 10, 2022
Open
@kaocher82 kaocher82 mentioned this pull request May 10, 2022
Open
This was referenced May 10, 2022
Open
Open
Open
Open
Open
@0xSebin 0xSebin mentioned this pull request Nov 29, 2022
Open
This was referenced Nov 29, 2022
Open
Open
This was referenced Nov 29, 2022
Open
Open
This was referenced Nov 29, 2022
Open
Open
Open
This was referenced Feb 28, 2023
Open
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 28, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Mar 1, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Mar 16, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Mar 16, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2023
Open
@saurabharch saurabharch mentioned this pull request Mar 21, 2023
Open
This was referenced Mar 28, 2023
Open
Open
@snyk-bot snyk-bot mentioned this pull request Apr 10, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Apr 19, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2023
Open
@monizb monizb mentioned this pull request Apr 20, 2023
Open
@kaocher82 kaocher82 mentioned this pull request May 4, 2023
Open
@kaocher82 kaocher82 mentioned this pull request May 12, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request May 23, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Jun 16, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisq21 @LekoArts