fix(gatsby): fix issue with decoding URl

[marvinjude]

Description

Using a percent encoded character like %25 in URL breaks due to multiple decodeURIComponent calls. This PR address this issue by making sure the query string part of the URL is always encoded.

Related Issues

Fixes #34797
Fixes #34998

[sc-46573]

[wardpeet]

To make sure do we have tests around query-strings without escaping and paths without escaping. Just making sure that we didn't miss any use case

[pieh]

To make sure do we have tests around query-strings without escaping and paths without escaping. Just making sure that we didn't miss any use case

@wardpeet We have quite a bit of e2e tests using regular query params. Some of them added for trailing slashes like

gatsby/e2e-tests/production-runtime/cypress/integration/1-production.js

Lines 211 to 222 in 1d3c331

	describe(`Keeps search query`, () => {
	describe(`No trailing slash canonical path (/slashes/no-trailing)`, () => {
	it(`/slashes/no-trailing?param=value`, () => {
	cy.visit(`/slashes/no-trailing?param=value`).waitForRouteChange()
	cy.getTestElement(`search-marker`)
	.invoke(`text`)
	.should(`equal`, `?param=value`)
	cy.location(`pathname`).should(`equal`, `/slashes/no-trailing`)
	cy.location(`search`).should(`equal`, `?param=value`)
	})

So we should be set for baseline testing and would need just add cases for specifically encoded ones which for now was added for e2e/dev-runtime (we should add same ones to e2e/prod-runtime as well to be sure)

[marvinjude]

We also have some here

gatsby/e2e-tests/development-runtime/cypress/integration/navigation/redirect.js

Lines 47 to 66 in 1d3c331

	it(`should support search parameter with Link component`, () => {
	cy.visit(`/`, {
	failOnStatusCode: false,
	}).waitForRouteChange()
	cy.getTestElement(`redirect-two-search`).click().waitForRouteChange()
	cy.location(`pathname`).should(`equal`, `/redirect-search-hash`)
	cy.location(`hash`).should(`equal`, ``)
	cy.location(`search`).should(`equal`, `?query_param=hello`)
	})
	it(`should support search parameter on direct visit`, () => {
	cy.visit(`/redirect-two?query_param=hello`, {
	failOnStatusCode: false,
	}).waitForRouteChange()
	cy.location(`pathname`).should(`equal`, `/redirect-search-hash`)
	cy.location(`hash`).should(`equal`, ``)
	cy.location(`search`).should(`equal`, `?query_param=hello`)
	})

[Abhirup-99]

Thanks for the PR and the approval. Do push a release with the changes as we are eagerly waiting for this :).

[marvinjude]

Hi @Abhirup-99,

You can test this out in gatsby@next - yarn add gatsby@next.