Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semicolons, clearer terminal instructions, spacing #3315

Merged
merged 2 commits into from
Dec 22, 2017

Conversation

shannonbux
Copy link
Contributor

Hope the terminal instructions are accurate. I tried to clarify when to install something at the root of the site vs. in a new terminal window. Not sure if it makes more sense to assume that people know what the root of the site means?

Also wondering if there's a way to automatically resize code examples to fit within whatever size the light pink box is so that right to left scrolling isn't necessary.

Hope the terminal instructions are accurate. I tried to clarify when to install something at the root of the site vs. in a new terminal window. Not sure if it makes more sense to assume that people know what the root of the site means?

Also wondering if there's a way to automatically resize code examples to fit within whatever size the light pink box is so that right to left scrolling isn't necessary.
@ghost ghost assigned shannonbux Dec 22, 2017
@ghost ghost added the review label Dec 22, 2017
@gatsbybot
Copy link
Collaborator

gatsbybot commented Dec 22, 2017

Deploy preview ready!

Built with commit 2b58683

https://deploy-preview-3315--gatsbygram.netlify.com

@ghost ghost assigned KyleAMathews Dec 22, 2017
@KyleAMathews
Copy link
Contributor

Looks great!

We do have a way to automatically make the inline code less wide — it's only working on some of the code blocks — those w/o highlighted lines as the line numbers break the code formatting. @bvaughn has an idea for fixing that though.

@KyleAMathews KyleAMathews merged commit 1ed989f into master Dec 22, 2017
@KyleAMathews KyleAMathews deleted the shannonbux-patch-1 branch December 22, 2017 22:59
@ghost ghost removed the review label Dec 22, 2017
@bvaughn
Copy link
Contributor

bvaughn commented Dec 23, 2017

👋 Still hope to find time to submit another PR about that at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants