test(contentful): improve content reference snapshot tests #31008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
axe312ger
commented
Apr 22, 2021
| }, | ||
| "content-reference-many-loop-a-greater-b": { | ||
| "1": "Content Reference: Many (Loop A -> B)[ContentfulInteger] 42[ContentfulText] The quick brown fox jumps over the lazy dog.[ContentfulReference] Content Reference: Many (Loop B -> A): [Content Reference: Many (Loop A -> B)]" | ||
| "1": "<div data-cy-id=\"content-reference-many-loop-a-greater-b\">\n <h2>Content Reference: Many (Loop A -> B)</h2>\n <p data-cy-id=\"integer\">[ContentfulInteger] 42</p>\n <p data-cy-id=\"text\">[ContentfulText] The quick brown fox jumps over the lazy\n dog.</p>\n <p data-cy-id=\"reference\">[ContentfulReference] Content Reference: Many (Loop\n B -> A): [Number: Integer, Text: Short, Content Reference: Many (Loop A\n -> B)]</p>\n</div>" |
There was a problem hiding this comment.
Number: Integer, Text: Short, These references actually have been missing from the query. The others PR's brought this to the surface.
axe312ger
added
status: needs core review
LekoArts
approved these changes
Apr 23, 2021
|
Thank you @LekoArts !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our content reference tests are the only once that snapshot the text instead of the DOM. As DOM comparison with
@cypress/snapshotis way more efficient when tests fail, this rewrites the tests.It also aligns the query to actually contain all available references.
This will help to reliable test and simplify #30855 && #31007