Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Fix argument order for onPreRouteUpdate #30339

Merged
merged 3 commits into from
Apr 12, 2023
Merged

fix(gatsby): Fix argument order for onPreRouteUpdate #30339

merged 3 commits into from
Apr 12, 2023

Commits on Mar 18, 2021

  1. Fix argument order for onPreRouteUpdate 

    The argument for `shouldComponentUpdate` is the *next* props, not the *previous* props, so `onPreRouteUpdate` was getting called with arguments in the reverse order.
    @StephenCleary
    StephenCleary authored Mar 18, 2021
    Configuration menu
    Copy the full SHA
    e64b4fc View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Merge branch 'master' into patch-1

    @graysonhicks
    graysonhicks authored Apr 7, 2023
    Configuration menu
    Copy the full SHA
    b558077 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Merge branch 'master' into patch-1

    @pieh
    pieh authored Apr 12, 2023
    Configuration menu
    Copy the full SHA
    5ad52d5 View commit details
    Browse the repository at this point in the history