fix(gatsby-plugin-image): Fix image rendering issues #30097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascorbic
added
the
topic: media
gatsbot
bot
added
the
status: triage needed
ascorbic
removed
the
status: triage needed
|
Let's get in the placeholder fix for now. I'm looking into the state issues, but relying on react for initial layout is something we don't want to do. |
|
@ascorbic Should we just remove it from the V3 fixes project or there is an alternative PR? |
|
@wardpeet is finishing up an alternative. |
|
OK, I've removed this one from the project for now. We'll add the alternative one instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously setting the sizer with dangerouslySetHTML before hydration, but this was causing rendering issues such as #29982, #30052 and #30024. This PR switches to rendering an empty layout wrapper as the placeholder instead. This is going to need some checking, as @laurieontech I know you did it like that for a reason!
This also no longer conditionally renders the placeholder, as this was causing a flicker, e.g. #29911. I can no longer reproduce the issue that was the reason I originally made this change, which was the blur-up happening even when an image was already loaded. If it returns, we should try fixing it with React.memo instead. Please let me know if you have a repro of that original issue.