Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): upgrade gatsby deps #29699

Closed
wants to merge 9 commits into from
Closed

Conversation

wardpeet
Copy link
Contributor

Description

Upgraded dependencies that seem non breaking

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 23, 2021
@wardpeet wardpeet force-pushed the chore/upgrade-gatsby branch from e12e9f2 to fcfbc61 Compare February 23, 2021 14:27
@wardpeet wardpeet changed the base branch from master to fix/remove-eslint-cache February 23, 2021 14:28
@wardpeet wardpeet added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 23, 2021
Base automatically changed from fix/remove-eslint-cache to master February 23, 2021 14:48
@wardpeet wardpeet force-pushed the chore/upgrade-gatsby branch from 4c4943e to 72d4a77 Compare February 24, 2021 00:53
@wardpeet wardpeet force-pushed the chore/upgrade-gatsby branch from 31bd315 to 40b6bca Compare February 25, 2021 07:33
@@ -24,15 +24,15 @@
"watch:polyfills": "microbundle -f iife -i src/polyfills.js --no-sourcemap --external=none --watch"
},
"dependencies": {
"core-js-compat": "^3.6.5"
"core-js-compat": "3.9.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll pin these deps as we don't really need auto updates for these as they could break snapshots which is not ideal. Normally renovatebot should create prs to upgrade.

"util.promisify": "^1.0.1",
"uuid": "3.4.0",
"util.promisify": "^1.1.1",
"uuid": "8.3.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we pinned it because the new versions included more stuff we didn't need. I recall some conversation on Slack about this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👍

"address": "1.1.2",
"anser": "^2.0.1",
"ansi-html": "^0.0.7",
"autoprefixer": "^9.8.4",
"autoprefixer": "^10.2.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"browserslist": "^4.12.2",
"cache-manager": "^2.11.1",
"browserslist": "^4.16.3",
"cache-manager": "^3.4.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"webpack-dev-middleware": "^4.1.0",
"webpack-dev-server": "^3.11.2",
"webpack-hot-middleware": "^2.25.0",
"webpack-merge": "^5.7.3",
"webpack-stats-plugin": "^1.0.3",
"webpack-virtual-modules": "^0.3.2",
"xstate": "^4.11.0",
"webpack-virtual-modules": "^0.4.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to keep this at 0.3.2, right?

@wardpeet wardpeet marked this pull request as draft February 25, 2021 10:34
@wardpeet wardpeet closed this Mar 1, 2021
@LekoArts LekoArts deleted the chore/upgrade-gatsby branch March 1, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants