Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(gatsby-transformer-yaml): Prefix id and only use createNodeId #28943

Merged
merged 10 commits into from
Oct 14, 2021
Merged

BREAKING(gatsby-transformer-yaml): Prefix id and only use createNodeId #28943

merged 10 commits into from
Oct 14, 2021

Conversation

joshmkennedy
Copy link
Contributor

Description

This pull request is a proposed solution to issue:#28846

Creates the key publicId on the object if the key id is present before the object is transformed

Fixes #28846

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 8, 2021
@joshmkennedy joshmkennedy marked this pull request as draft January 9, 2021 00:20
@joshmkennedy joshmkennedy marked this pull request as ready for review January 9, 2021 01:12
@LekoArts LekoArts added topic: transformers breaking change If implemented, this proposed work would break functionality for older versions of Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 12, 2021
@LekoArts LekoArts changed the title Bug/duplicate id lost gt yaml BREAKING(gatsby-transformer-yaml): Prefix id and only use createNodeId Jan 12, 2021
@LekoArts LekoArts mentioned this pull request Jan 12, 2021
Merged
@LekoArts
Copy link
Contributor

Hi, thanks for the PR! Looking at the snapshots the prefix didn't work here. Please see #28942 (comment) for further details on how I'd see both changes.

@marcus13371337
Copy link

I'm also experiencing this issue. Any workarounds until a PR can be merged? Anything I can pass into options of this plugin to get it fixed?

@marcus13371337
Copy link

Solved it by adding the onPreInit-function which loops through my yaml-files and removes the id field

@LekoArts LekoArts added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed topic: transformers labels May 28, 2021
LekoArts
LekoArts approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and sorry for the long wait on this! This will be released alongside Gatsby 4 (when we publish all packages as new major anyways)

@LekoArts LekoArts merged commit 76f0224 into gatsbyjs:master Oct 14, 2021
wardpeet pushed a commit to herecydev/gatsby that referenced this pull request Oct 29, 2021
@joshmkennedy @LekoArts @wardpeet
BREAKING(gatsby-transformer-yaml): Prefix id and only use createNod…
e58b594 
…eId (gatsbyjs#28943)

Co-authored-by: LekoArts <lekoarts@gmail.com>
axe312ger pushed a commit that referenced this pull request Nov 9, 2021
@joshmkennedy @LekoArts @axe312ger
BREAKING(gatsby-transformer-yaml): Prefix id and only use createNod…
76b11b7 
…eId (#28943)

Co-authored-by: LekoArts <lekoarts@gmail.com>
@ScottG489 ScottG489 mentioned this pull request Apr 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar left review comments

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
breaking change If implemented, this proposed work would break functionality for older versions of Gatsby topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gatsby-transformer-json] entities with duplicate IDs cause lost data
4 participants
@joshmkennedy @LekoArts @marcus13371337 @vladar