perf(gatsby): do not call and iterate getAllNodes(File) for each file #28891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: performance
… this is what we ended up with and I do not wish to discuss this any further
…ed set of arrays containing nodes, not a flat array. Then me and TS had another argument and we seem cool now.
pvdz
commented
Jan 8, 2021
Comment on lines
+31
to
+32
| type nestedListOfStrings = Array<string | nestedListOfStrings> | ||
| type nestedListOfNodes = Array<IGatsbyNode | nestedListOfNodes> |
There was a problem hiding this comment.
Funsies. But turns out the resulting nesting structure must match the input nesting structure. So if you have [a, [b, [c, d]]] as input, then your output should be the same except the input strings are replaced with nodes.
This is a tad annoying since it means we can't "just" pass on a flat array of promises to Promise.all() but so be it.
There was a problem hiding this comment.
I realise this is already merged, but types should be PascalCased
sidharthachatterjee
approved these changes
Jan 8, 2021
|
Awesome work, @pvdz |
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it would call
context.nodeModel.getAllNodes({ type: `File` })(already a non-trivial operation on its own) and then filter that down to the one node it was looking for; the one that represents the file. This approach is not cached, super slow, and simply does not scale.This PR changes that approach to leverage the fast filters, which will generate a O(1) lookup cache on the first call. The rest of the calls will be O(1) lookups.
Tested this on a modification of
benchmarks/gabe-fs-markdownwhich adds one image per page (randomly generated before the benchmark).This effect scales as the number of nodes goes up. This should apply to most things that relate to local files, and maybe even beyond that.
This is a massive win for local file usage
just sayin'