fix(gatsby): show stack trace for non-graphql errors #28888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pvdz
added
topic: cli
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
* fix(gatsby): show stack trace for non-graphql errors * If we want to squash more graphql specific errors we should catch them * one attempt at fixing snapshots * Drop unused imported type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR the error would be swallowed because it wasn't passed on by
packages/gatsby/src/query/error-parser.ts. This would mean that the panicOnBuild would never see the original error and would therefor not be able to print the stack, even if that was desirable. By passing the original error object on, it'll do this once again.The error is not passed on if it is a graphql error, because the code frame is most likely more relevant here.