Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecommerce conceptual guide #28755

Merged
merged 4 commits into from
Jan 8, 2021
Merged

ecommerce conceptual guide #28755

merged 4 commits into from
Jan 8, 2021

Conversation

calcsam
Copy link
Contributor

@calcsam calcsam commented Dec 26, 2020

Add an overview of the considerations necessary when building an e-commerce site with Gatsby and eg Shopify

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 26, 2020
jemond
jemond reviewed Dec 31, 2020
View reviewed changes
Copy link

@jemond jemond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice write up! My new $0.02 are inline - let me know if you need any clarifications on anything.

docs/docs/conceptual/gatsby-for-ecommerce.md Outdated Show resolved Hide resolved
docs/docs/conceptual/gatsby-for-ecommerce.md Outdated Show resolved Hide resolved
docs/docs/conceptual/gatsby-for-ecommerce.md Outdated Show resolved Hide resolved
docs/docs/conceptual/gatsby-for-ecommerce.md Outdated Show resolved Hide resolved
docs/docs/conceptual/gatsby-for-ecommerce.md Outdated Show resolved Hide resolved
docs/docs/conceptual/gatsby-for-ecommerce.md Outdated Show resolved Hide resolved
docs/docs/conceptual/gatsby-for-ecommerce.md Outdated Show resolved Hide resolved
docs/docs/conceptual/gatsby-for-ecommerce.md Show resolved Hide resolved
docs/docs/conceptual/gatsby-for-ecommerce.md Show resolved Hide resolved
@LekoArts LekoArts added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 4, 2021
meganesu
meganesu previously approved these changes Jan 6, 2021
View reviewed changes
@calcsam
Copy link
Contributor Author

calcsam commented Jan 8, 2021

thanks for the approval @meganesu and comments @jemond! it seems approval got dismissed 🤔 -- going to squash and merge this in.

@calcsam calcsam merged commit ac8d00c into master Jan 8, 2021
@calcsam calcsam deleted the ecommerce-concpetual-guide branch January 8, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemond jemond jemond left review comments

@meganesu meganesu meganesu left review comments

Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@calcsam @jemond @meganesu @LekoArts @calcsam2