test(cache-resilience): update snapshots #28703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
force-pushed
the
fix/cache-resilience-snapshots-update-after-child-fields-adjustment
branch
from
300f7f7
to
2471d64
Compare
pieh
added
topic: GraphQL
vladar
approved these changes
Dec 21, 2020
vladar
deleted the
fix/cache-resilience-snapshots-update-after-child-fields-adjustment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently not required cache resilience tests needed to be updated in #28656 but we slapped merge on green which doesn't require "not required" tests to pass (ops). This just updates snapshots for those tests to match change from that PR (always adding both
childXandchildrenXfields. Snapshots here introspect schema for various scenarios and compares what happens to schema when adding/removing plugins between runs.It only have cases for single child scenario so it did had just
childXbefore - with change from PR we now have to account forchildrenXtoo.Related Issues
#28656