fix(gatsby-cli): fix timers on progress bar #28684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pvdz
added
topic: cli
pieh
previously approved these changes
Dec 18, 2020
pieh
added
the
bot: merge on green
pieh
approved these changes
Jan 5, 2021
| @@ -93,15 +93,27 @@ export function initializeYurnalistLogger(): void { | |||
| activities[action.payload.id] = activity | |||
| } else if (action.payload.type === ActivityTypes.Progress) { | |||
| const bar = new ProgressBar( | |||
| ` [:bar] :current/:total :elapsed s :percent ${action.payload.text}`, | |||
| ` [:bar] :current/:total :elapsed s :rate /s :percent ${action.payload.text}`, | |||
There was a problem hiding this comment.
Nit (feel free to ignore)
Suggested change
| ` [:bar] :current/:total :elapsed s :rate /s :percent ${action.payload.text}`, | |
| ` [:bar] :current/:total :elapseds :rate/s :percent ${action.payload.text}`, |
extra space there make it look a bit weird (like it was something separate) - this change does in fact result in
-[=====-------------------------] 18/100 1.5 s 12 /s 18% test #1
+[=====-------------------------] 18/100 1.5s 12/s 18% test #1"postfixes" are "attached" to their numbers which to me make it more clear what those are (IMO)
but up to you and feel free to ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes something I've seen for a while now. The progress bar in yurnalist (CI=1) will not show you an ETA or total runtime of the progress bar. It remains zero.
Apparently this is caused by a bug by setting
currwhen creating the progress bar. See visionmedia/node-progress#81The workaround is to call
bar.tick(n)instead. This will cause an incorrect eta when starting from non-zero but at least it'll show you something, and show you the current runtime.Looking at the repo, I'm not expecting any more fixes for this package.