Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-page-creator): add missing telemetry dependency #28652

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Dec 16, 2020

Description

We import gatsby-telemetry in gatsby-plugin-page-creator but we don't set it as dependency so sometimes depending how package managers install node_modules this can result in "Module not found" errors

import { trackFeatureIsUsed } from "gatsby-telemetry"

Related Issues

Fixes #28646

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 16, 2020
@pieh pieh added topic: telemetry* and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 16, 2020
@vladar
Copy link
Contributor

vladar commented Dec 16, 2020

We should treat this one with care when cherry-picking as it needs to be ^1.7.0-next.0 in the release branch (not ^1.8.0-next.0).

@pieh
Copy link
Contributor Author

pieh commented Dec 16, 2020

needs to be ^1.7.0-next.0

1.7.0 I think? (not -next.0 :P) But yes - this entire PR will be a merge conflcit when backporting.

@vladar
Copy link
Contributor

vladar commented Dec 16, 2020

You are correct, it is 1.7.0 😄 It would've been 1.7.0-next.0 during the stabilization phase.

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 16, 2020
@gatsbybot gatsbybot merged commit a13827f into master Dec 16, 2020
@gatsbybot gatsbybot deleted the fix/gppc/add-telemetry-as-dep branch December 16, 2020 13:40
LekoArts pushed a commit that referenced this pull request Dec 16, 2020
LekoArts added a commit that referenced this pull request Dec 16, 2020
…8652) (#28658)

(cherry picked from commit a13827f)

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
@LekoArts
Copy link
Contributor

Published in gatsby-plugin-page-creator@2.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'gatsby-telemetry'
4 participants