Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-image): Better propType handling for StaticImage #28606

Merged
merged 3 commits into from
Dec 15, 2020
Merged

fix(gatsby-plugin-image): Better propType handling for StaticImage #28606

merged 3 commits into from
Dec 15, 2020

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Dec 14, 2020 •
edited
Loading

Check layout proptype in StaticImage. Be more forgiving about capitalisation of prop values
[ch21131]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 14, 2020
@LekoArts LekoArts added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 14, 2020
@ascorbic ascorbic mentioned this pull request Dec 15, 2020
Merged
mxstbr
mxstbr approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 I love it!!!

@ascorbic ascorbic merged commit 52027db into master Dec 15, 2020
@ascorbic ascorbic deleted the fix/static-image-proptype branch December 15, 2020 12:02
@ascorbic
Copy link
Contributor Author

@mxstbr Hopefully this should fix your issue

LekoArts pushed a commit that referenced this pull request Dec 15, 2020
@ascorbic @LekoArts
fix(gatsby-plugin-image): Better propType handling for StaticImage (#…
298209d 
…28606)

* fix(gatsby-plugin-image): Better propType handling for StaticImage

* Normalise props

* Handle tracedSVG not being camel case

(cherry picked from commit 52027db)
LekoArts pushed a commit that referenced this pull request Dec 15, 2020
@ascorbic @LekoArts
fix(gatsby-plugin-image): Better propType handling for StaticImage (#…
d41cdb1 
…28606)

* fix(gatsby-plugin-image): Better propType handling for StaticImage

* Normalise props

* Handle tracedSVG not being camel case

(cherry picked from commit 52027db)
@LekoArts LekoArts mentioned this pull request Dec 15, 2020
Merged
LekoArts added a commit that referenced this pull request Dec 15, 2020
@LekoArts @ascorbic
fix(gatsby-plugin-image): Better propType handling for StaticImage (#…
5901a10 
…28606) (#28628)

* fix(gatsby-plugin-image): Better propType handling for StaticImage

* Normalise props

* Handle tracedSVG not being camel case

(cherry picked from commit 52027db)

Co-authored-by: Matt Kane <matt@gatsbyjs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxstbr mxstbr mxstbr approved these changes

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ascorbic @mxstbr @LekoArts