fix(query-on-demand): don't resolve get-page-data if query is marked as dirty #28535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
force-pushed
the
qod/handle-potential-dead-lock-between-get-page-data-and-flush-page-data
branch
from
243ad52
to
86fc037
Compare
pieh
removed
the
status: triage needed
pieh
changed the title
pieh
commented
Dec 8, 2020
packages/gatsby/src/redux/__tests__/__snapshots__/index.js.snap
Outdated
Show resolved
Hide resolved
vladar
previously approved these changes
Dec 8, 2020
vladar
approved these changes
Dec 9, 2020
pieh
deleted the
qod/handle-potential-dead-lock-between-get-page-data-and-flush-page-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently have potential dead lock situation as we skip writing
page-data(in query on demand only!) when query is marked as dirty. This means thatgetPageDatacan not resolve (or rather resolve with stale data due to timeout guards) if:This PR only skips flushing page-data if query didn't run yet (
FLAG_DIRTY_NEW_PAGEcheck instead of checking if query is dirty for whatever reason) and triggers another run ofdoGetPageDatathat checks if query is dirty / running / pending to trigger another run if it's in fact still dirty after flushing page-data.I'm uncertain about not touching part that does emit websocket message - in this case we might not resolve
getPageDataafter flushing but still emit websocket update. This should not cause weirdness withloadPagethat fetches data, but because we have single cache that is being saturated from fetch requests and websocket updates it could potentially result in weirdness but to repro it it would have to be real weird timing scenario.[ch19354]