fix(gatsby): Wait for jobs to complete in onPostBuild #28534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
sidharthachatterjee
removed
the
status: triage needed
ascorbic
approved these changes
Dec 8, 2020
wardpeet
added
the
bot: merge on green
pieh
pushed a commit
that referenced
this pull request
Dec 9, 2020
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com> (cherry picked from commit 98f22e7)
pieh
pushed a commit
that referenced
this pull request
Dec 9, 2020
|
Published in |
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins can currently run queries in
onPostBuildif they like. If these queries trigger side effects like jobs, they are currently not awaited inonPostBuild. This is a bug.We fix this by waiting till the jobs queue is empty.
An example of a community plugin that does this is https://github.com/dominicfallows/gatsby-plugin-json-output