feat(gatsby-plugin-page-creator): Add slugify option #28485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: page creation
and removed
status: triage needed
LekoArts
commented
Dec 7, 2020
| @@ -11,13 +12,13 @@ import { collectionExtractQueryString } from "./collection-extract-query-string" | |||
| import { isValidCollectionPathImplementation } from "./is-valid-collection-path-implementation" | |||
| import { CODES, prefixId } from "./error-utils" | |||
|
|
|||
| // TODO: Do we need the ignore argument? | |||
There was a problem hiding this comment.
No, because before this function is called, ignore is already handled:
pvdz
previously approved these changes
Dec 7, 2020
pvdz
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28470
We use slugify in our derivePath function to generate the path for every File System Route API page. Since people are able to choose their own path when using
createPagesAPI we should also expose the options for this functionality to offer the most flexibility.With this PR I'm simply passing the option through to the derivePath function. As it's a bit nested a bunch of functions needed to be changed.
The TS types for the
IOptionsinterface oncreatePagesStatefullywere also incorrect, so I had to enable type generation on ourgatsby-page-utilsto accessIPathIgnoreOptions.Documentation
I've updated the README to also include a short example of overriding src/pages defaults + added a new table for all the options. For the pipes on the type I used a divisor
∣as MDX has a bug (mdx-js/mdx#838) of not recognizing escaped pipes (we're on a too old version of MDX/remark).[ch20379]