Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby-source-contentful): drop unnecessary promise, _.get #28439

Merged
merged 2 commits into from
Dec 2, 2020
Merged

chore(gatsby-source-contentful): drop unnecessary promise, _.get #28439

merged 2 commits into from
Dec 2, 2020

Conversation

pvdz
Copy link
Contributor

@pvdz pvdz commented Dec 2, 2020 •
edited
Loading

This PR does three things twice;

  • Drop a Promise.resolve for a value that is not a promise in a function (resolver) that can but does not need to return a promise
  • Makes the resolver a proper method, rather than an arrow property
  • Drop a few cases of _.get in favor of actual ?. syntax

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 2, 2020
@pvdz pvdz added topic: source-contentful Related to Gatsby's integration with Contentful type: chore and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 2, 2020
@pvdz pvdz merged commit 299489c into master Dec 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the nonpromise branch December 2, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar approved these changes

Assignees
No one assigned
Labels
topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvdz @vladar