Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Quickstart update #27860

Merged
merged 6 commits into from
Dec 2, 2020
Merged

Docs: Quickstart update #27860

merged 6 commits into from
Dec 2, 2020

Conversation

laurieontech
Copy link
Contributor

Update quickstart to account for new npm init gatsby command.

[ch17777]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 5, 2020
@laurieontech laurieontech added status: needs docs review Pull request related to documentation waiting for review and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 5, 2020
fk
fk reviewed Nov 5, 2020
View reviewed changes
docs/docs/quick-start.md Outdated Show resolved Hide resolved
meganesu
meganesu reviewed Nov 5, 2020
View reviewed changes
docs/docs/quick-start.md Outdated Show resolved Hide resolved
LB and others added 2 commits November 5, 2020 14:42
@meganesu
Update docs/docs/quick-start.md
d699d1d 
Co-authored-by: Megan Sullivan <megan@gatsbyjs.com>
update next steps
814ef1a
@LekoArts
Copy link
Contributor

LekoArts commented Nov 9, 2020

How about also changing the root README in this repository?

@laurieontech
Copy link
Contributor Author

@LekoArts good catch. @meganesu how do we feel about that? Both the root README and gatsby README could be updated as part of this.

@meganesu
Copy link
Contributor

@LekoArts good catch. @meganesu how do we feel about that? Both the root README and gatsby README could be updated as part of this.

That makes sense to me! We should def be consistent with how we're recommending folks get started. I'm wondering if it makes sense for the READMEs to link to the Quick Start (instead of having duplicate content) so that there's only a single source of truth?

@meganesu meganesu removed the status: needs docs review Pull request related to documentation waiting for review label Nov 16, 2020
Anmol368
Anmol368 previously approved these changes Nov 17, 2020
View reviewed changes
meganesu
meganesu reviewed Nov 30, 2020
View reviewed changes
docs/docs/quick-start.md Outdated Show resolved Hide resolved
@meganesu
Update docs/docs/quick-start.md
31b1096 
Co-authored-by: Megan Sullivan <megan@gatsbyjs.com>
@laurieontech laurieontech changed the title (WIP) Docs: Quickstart update Docs: Quickstart update Dec 2, 2020
@laurieontech laurieontech marked this pull request as ready for review December 2, 2020 16:37
mxstbr
mxstbr approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesssss 🎉 🎉 🎉

@laurieontech laurieontech merged commit 3d4dd59 into master Dec 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the update-quickstart branch December 2, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fk fk fk left review comments

@meganesu meganesu meganesu left review comments

@mxstbr mxstbr mxstbr approved these changes

@Anmol368 Anmol368 Anmol368 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@laurieontech @LekoArts @meganesu @fk @mxstbr @Anmol368