Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-remark-autolink-headers): remove incorrect default value for icon option #27821

Merged
merged 1 commit into from
Nov 4, 2020
Merged

fix(gatsby-remark-autolink-headers): remove incorrect default value for icon option #27821

merged 1 commit into from
Nov 4, 2020

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Nov 4, 2020

Closes #27813. This should be defaulted to undefined, as true isn't supported.

@mxstbr mxstbr requested a review from a team as a code owner November 4, 2020 07:35
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 4, 2020
@LekoArts LekoArts added topic: remark/mdx Related to Markdown, remark & MDX ecosystem and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 4, 2020
LekoArts
LekoArts approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LekoArts LekoArts merged commit 2d2f949 into master Nov 4, 2020
@LekoArts LekoArts deleted the autolink-headers/fix-icon-default branch November 4, 2020 08:17
vladar pushed a commit that referenced this pull request Nov 4, 2020
@mxstbr @vladar
fix(gatsby-remark-autolink-headers): remove incorrect default value f…
8f82d7b 
…or icon option (#27821)

(cherry picked from commit 2d2f949)
@vladar vladar mentioned this pull request Nov 4, 2020
Merged
vladar added a commit that referenced this pull request Nov 4, 2020
@vladar @mxstbr
fix(gatsby-remark-autolink-headers): remove incorrect default value f…
dbf41c8 
…or icon option (#27821) (#27830)

(cherry picked from commit 2d2f949)

Co-authored-by: Max Stoiber <contact@mxstbr.com>
@vladar vladar mentioned this pull request Nov 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: remark/mdx Related to Markdown, remark & MDX ecosystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gatsby-remark-autolink-headers includes text "true" before each heading
2 participants
@mxstbr @LekoArts