Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update plugin schema testing util and associated tests #27574

Merged
merged 11 commits into from
Oct 21, 2020

Conversation

laurieontech
Copy link
Contributor

@laurieontech laurieontech commented Oct 20, 2020

The plugin schema testing util was using separate functionality causing a diff between valid schemas and those that passed tests. This PR updates the testing util to use our production validation function and makes all existing tests compatible with this change.

Note it also includes an addition to the gatsby-plugin-typescript schema that was the reason this was uncovered.

[ch17569]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 20, 2020
@laurieontech laurieontech added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 20, 2020
@wardpeet wardpeet changed the title fix(packages*): Update plugin schema testing util and associated tests fix: Update plugin schema testing util and associated tests Oct 20, 2020
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessss this is fantastic! Thank you!! 🙌

@mxstbr mxstbr merged commit 6d81283 into master Oct 21, 2020
@mxstbr mxstbr deleted the typescript-when-validation branch October 21, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants