Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby-remark-images): add pluginOptionsSchema export #27439

Merged
merged 5 commits into from
Oct 14, 2020
Merged

chore(gatsby-remark-images): add pluginOptionsSchema export #27439

merged 5 commits into from
Oct 14, 2020

Conversation

mfrachet
Copy link
Contributor

Description

Add plugin schema options in gatsby-remark-images

Relates to #27242 and https://www.gatsbyjs.com/plugins/gatsby-remark-images/

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 14, 2020
@mfrachet mfrachet removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 14, 2020
@mfrachet mfrachet marked this pull request as ready for review October 14, 2020 11:42
mxstbr
mxstbr approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic!

We should even be able to generate the exact same options table that is in the gatsby-remark-images README from this 😍

@mfrachet mfrachet merged commit 27ae3aa into gatsbyjs:master Oct 14, 2020
@mfrachet mfrachet deleted the plugin-options-schema-remark-images branch October 14, 2020 12:27
@MichaelDeBoey MichaelDeBoey mentioned this pull request Oct 22, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Nov 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxstbr mxstbr mxstbr approved these changes

@ascorbic ascorbic Awaiting requested review from ascorbic

@laurieontech laurieontech Awaiting requested review from laurieontech

@gillkyle gillkyle Awaiting requested review from gillkyle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfrachet @mxstbr