Update kintohub documentation with kintohub V1 deployment #27016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
added
status: needs docs review
|
Hey @ascorbic, |
meganesu
reviewed
Nov 16, 2020
docs/docs/deploying-to-kintohub.md
Outdated
|
|
||
| ## Deployment Configuration | ||
| 3. Grant the permission needed for accessing the repo that we created in the previous step. Or if you prefer not to connect your GitHub account, you may select **Import URL** and provide your access token. |
There was a problem hiding this comment.
Per the Style Guide, docs should use "you" instead of "we".
Suggested change
| 3. Grant the permission needed for accessing the repo that we created in the previous step. Or if you prefer not to connect your GitHub account, you may select **Import URL** and provide your access token. | |
| 3. Grant the permission needed for accessing the repo that you created in the previous step. Or if you prefer not to connect your GitHub account, you may select **Import URL** and provide your access token. |
meganesu
suggested changes
Nov 16, 2020
docs/docs/deploying-to-kintohub.md
Outdated
|
|
||
| You can configure additional features directly from your Project page. | ||
| If you're not already there, select **Projects** on the left-hand navigation bar, and then click on the project you want to configure. | ||
| 4. Configure the service. Add the build command `yarn && yarn build` This command is actually doing the following: |
There was a problem hiding this comment.
Suggested change
| 4. Configure the service. Add the build command `yarn && yarn build` This command is actually doing the following: | |
| 4. Configure the service. Add the build command `yarn && yarn build`. This command is actually doing the following: |
docs/docs/deploying-to-kintohub.md
Outdated
Comment on lines
23
to
25
| - Install the dependencies | ||
| - Run the gatsby build | ||
| - Generate the contents to `./public` which is the default value of “Build Output Path” |
There was a problem hiding this comment.
Suggested change
| - Install the dependencies | |
| - Run the gatsby build | |
| - Generate the contents to `./public` which is the default value of “Build Output Path” | |
| - Install the dependencies. | |
| - Run `gatsby build`. | |
| - Put the generated site into the `./public` directory, which is the default value of “Build Output Path”. |
docs/docs/deploying-to-kintohub.md
Outdated
|
|
||
| Wait for the deployment to be successful. | ||
| Refresh the page, your website is now protected. | ||
| 6. Once the deployment is finished you can close the release logs, check the **Access tab** and copy the url there. Paste it to the browser and you will see your website is live! |
There was a problem hiding this comment.
Suggested change
| 6. Once the deployment is finished you can close the release logs, check the **Access tab** and copy the url there. Paste it to the browser and you will see your website is live! | |
| 6. Once the deployment is finished you can close the release logs, check the **Access tab** and copy the URL there. Paste it to the browser and you will see your website is live! |
docs/docs/deploying-to-kintohub.md
Outdated
Comment on lines
34
to
37
| 2. Enter your domain or subdomain you wish to map to your service | ||
| 3. Click **Add Domain** | ||
| 4. Follow the instructions to add a **CNAME** key and value to your DNS host provider | ||
| 5. Click **OK** |
There was a problem hiding this comment.
Suggested change
| 2. Enter your domain or subdomain you wish to map to your service | |
| 3. Click **Add Domain** | |
| 4. Follow the instructions to add a **CNAME** key and value to your DNS host provider | |
| 5. Click **OK** | |
| 2. Enter your domain or subdomain you wish to map to your service. | |
| 3. Click **Add Domain**. | |
| 4. Follow the instructions to add a **CNAME** key and value to your DNS host provider. | |
| 5. Click **OK**. |
meganesu
added
type: documentation
LekoArts
added
the
status: awaiting author response
|
Hi @bappr 👋 Can you solve the merge conflict and address the change requests? |
meganesu
approved these changes
Dec 9, 2020
meganesu
removed
the
status: awaiting author response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
KintoHub released their new version and the doc needs to be updated.