Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-source-drupal): Add skipFileDownloads config option #25029

Conversation

smthomas
Copy link
Contributor

@smthomas smthomas commented Jun 16, 2020

Description

This PR adds a skipFileDownloads config option to gatsby-source-drupal. This is useful when using a Drupal site and some third party image processing solution. By enabling this config option Gatsby will not download the remote files which will significantly speed up builds that don't use Gatsby's image processing.

Documentation

This is documented in the gatsby-source-drupal plugin README file.

Related Issues

This change would help with issues like this #24257

@smthomas smthomas added the topic: source-drupal Related to Gatsby's integration with Drupal label Jun 16, 2020
@smthomas smthomas requested review from a team as code owners June 16, 2020 18:11
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 16, 2020
@smthomas smthomas added status: inkteam assigned status: needs core review Currently awaiting review from Core team member and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 16, 2020
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that the logic in packages/gatsby-source-drupal/src/utils.js is correct?

packages/gatsby-source-drupal/src/utils.js Outdated Show resolved Hide resolved
pvdz
pvdz previously approved these changes Jun 17, 2020
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful for debugging, if nothing else. Thanks!

packages/gatsby-source-drupal/src/__tests__/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README looks good. I don't think any additional docs changes are necessary as part of this PR.

@smthomas smthomas added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jun 18, 2020
@gatsbybot gatsbybot merged commit 39d4cec into gatsbyjs:master Jun 18, 2020
axe312ger pushed a commit that referenced this pull request Jun 23, 2020
* Add gatsby-source-drupal skipFileDownloads config option

* Add gatsby-source-drupal skipFileDownloads test

* Fix skipFileDownlaods logic error on webhook updates

* Add additional gatsby-source-drupal skipFileDownlaods test
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
…byjs#25029)

* Add gatsby-source-drupal skipFileDownloads config option

* Add gatsby-source-drupal skipFileDownloads test

* Fix skipFileDownlaods logic error on webhook updates

* Add additional gatsby-source-drupal skipFileDownlaods test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes status: needs core review Currently awaiting review from Core team member topic: source-drupal Related to Gatsby's integration with Drupal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants