-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-source-drupal): Add skipFileDownloads config option #25029
feat(gatsby-source-drupal): Add skipFileDownloads config option #25029
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm that the logic in packages/gatsby-source-drupal/src/utils.js is correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very helpful for debugging, if nothing else. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README looks good. I don't think any additional docs changes are necessary as part of this PR.
* Add gatsby-source-drupal skipFileDownloads config option * Add gatsby-source-drupal skipFileDownloads test * Fix skipFileDownlaods logic error on webhook updates * Add additional gatsby-source-drupal skipFileDownlaods test
…byjs#25029) * Add gatsby-source-drupal skipFileDownloads config option * Add gatsby-source-drupal skipFileDownloads test * Fix skipFileDownlaods logic error on webhook updates * Add additional gatsby-source-drupal skipFileDownlaods test
Description
This PR adds a skipFileDownloads config option to gatsby-source-drupal. This is useful when using a Drupal site and some third party image processing solution. By enabling this config option Gatsby will not download the remote files which will significantly speed up builds that don't use Gatsby's image processing.
Documentation
This is documented in the gatsby-source-drupal plugin README file.
Related Issues
This change would help with issues like this #24257