Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-manifest): remove fs from ssr #24097

Merged
merged 2 commits into from
May 15, 2020
Merged

fix(gatsby-plugin-manifest): remove fs from ssr #24097

merged 2 commits into from
May 15, 2020

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented May 14, 2020 •
edited
Loading

Description

gatsby-ssr was using fs to get contentdigest of the icon to use as cacheKey. If we want to move to a distributed world. Fs shouldn't run in ssr mode.

Documentation

Only internal stuff has changed so no need for updates

@wardpeet wardpeet requested a review from a team as a code owner May 14, 2020 17:48
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 14, 2020
@pieh pieh added status: needs core review Currently awaiting review from Core team member and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 14, 2020
pieh
pieh approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do miss some nicer ways of passing information between context (node -> ssr) as mutating pluginOptions is bit ... "meh", but we also don't have any other way right now so this is good to go in IMO.

Thanks for handling it!

@wardpeet wardpeet merged commit 846b59a into gatsbyjs:master May 15, 2020
@wardpeet wardpeet deleted the fix/manifest-ssr branch May 15, 2020 12:16
@pvdz
Copy link
Contributor

pvdz commented May 18, 2020

Published in gatsby-plugin-manifest@2.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
status: needs core review Currently awaiting review from Core team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wardpeet @pvdz @pieh