Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify Tutorial Part 7 #23775

Merged
merged 1 commit into from
May 5, 2020
Merged

docs: clarify Tutorial Part 7 #23775

merged 1 commit into from
May 5, 2020

Conversation

adamu
Copy link
Contributor

@adamu adamu commented May 5, 2020

Added a clarification to avoid a common error when following the tutorial, which is to forget to add getNode to the function parameters.

This happeed to me, and looks like it's happened to a few others too.

Hopefully this will help avoid other people making the same mistake.

Added a clarification to avoid a common error when following the
tutorial, which is to forget to add `getNode` to the function
parameters: https://stackoverflow.com/questions/53870443/getnode-method-not-found-in-gatsby-node-js-with-the-latest-version-of-gatsby
@adamu adamu requested a review from a team as a code owner May 5, 2020 07:05
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 5, 2020
@LekoArts LekoArts added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 5, 2020
Copy link
Contributor

@gillkyle gillkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adamu! Seeing the StackOverflow thread helps highlight how this change will be helpful.

I think this additional clarity is great 🎉

@gillkyle gillkyle changed the title Clarify Tutorial Part 7 docs: clarify Tutorial Part 7 May 5, 2020
@gillkyle gillkyle merged commit 5d69786 into gatsbyjs:master May 5, 2020
@gatsbot
Copy link

gatsbot bot commented May 5, 2020

Holy buckets, @adamu — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants