Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gatsby-link] Add helper withPrefix method #2329

Merged
merged 6 commits into from
Oct 18, 2017
Merged

[gatsby-link] Add helper withPrefix method #2329

merged 6 commits into from
Oct 18, 2017

Conversation

kripod
Copy link
Contributor

@kripod kripod commented Oct 4, 2017

Resolves #2254

@KyleAMathews
Copy link
Contributor

Hmm but this isn't exposed so doesn't help you prefix links in your own code.

@KyleAMathews KyleAMathews reopened this Oct 5, 2017
@kripod
Copy link
Contributor Author

kripod commented Oct 5, 2017

@KyleAMathews Cannot it be imported using import { withPrefix } from 'gatsby-link'? If not, then I would appreciate if you could suggest a better location for exposure.

@KyleAMathews
Copy link
Contributor

Haha, so it is. Didn't read that closely enough obviously.

Could you update the README as well to document this change.

@kripod
Copy link
Contributor Author

kripod commented Oct 13, 2017

Sure, I will, as soon as I have some free time 😊

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Oct 18, 2017 •
edited
Loading

Deploy preview failed.

Built with commit 09be09c

https://app.netlify.com/sites/using-glamor/deploys/59e7aaafa6188f51df6a4811

kripod and others added 2 commits October 18, 2017 09:57
@kripod
Merge pull request #1 from kripod/patch-2
e8ed801 
[gatsby-link] Add docs for `withPrefix`
@KyleAMathews
Tweak copy
09be09c
@KyleAMathews
Copy link
Contributor

Thanks!

@KyleAMathews KyleAMathews merged commit 644f131 into gatsbyjs:master Oct 18, 2017
kripod
kripod commented Oct 19, 2017
View reviewed changes
Copy link
Contributor Author

@kripod kripod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping me out, the new explanation is definitely more explicit and expressive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kripod @KyleAMathews