(blog)challenge 10 of 100daysofgatsby #21969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ekwuno
reviewed
Mar 5, 2020
Ekwuno
suggested changes
Mar 5, 2020
There was a problem hiding this comment.
Hey, I just went through and I left a few suggestions. One thing that I'd like to point out is the use of "we" per the style guide it is advised to avoid using the first person. I feel like it should be reworded a bit. let me know your thoughts. In the context "we" is being used it refers to "Gatsby".
Co-Authored-By: Obinna Ekwuno <obinnacodes@gmail.com>
|
thanks for pointing that out @Ekwuno . I made the changes you requested. |
hashimwarren
changed the title
bebrian458
pushed a commit
to bebrian458/gatsby
that referenced
this pull request
Mar 5, 2020
* Draft challenge 10 of 100daysofgatsby * chore: format * Fix challenge number * Fix typos and add addititional links. * Update docs/blog/100days/performance/index.md Co-Authored-By: Obinna Ekwuno <obinnacodes@gmail.com> * Remove "first person" as per style guide Co-authored-by: GatsbyJS Bot <mathews.kyle+gatsbybot@gmail.com> Co-authored-by: Obinna Ekwuno <obinnacodes@gmail.com>
bebrian458
added a commit
to bebrian458/gatsby
that referenced
this pull request
Mar 5, 2020
This reverts commit 36daee0.
gatsbybot
pushed a commit
that referenced
this pull request
Mar 5, 2020
….5 gb (#21993) * (blog)Draft challenge 10 of 100daysofgatsby (#21969) * Draft challenge 10 of 100daysofgatsby * chore: format * Fix challenge number * Fix typos and add addititional links. * Update docs/blog/100days/performance/index.md Co-Authored-By: Obinna Ekwuno <obinnacodes@gmail.com> * Remove "first person" as per style guide Co-authored-by: GatsbyJS Bot <mathews.kyle+gatsbybot@gmail.com> Co-authored-by: Obinna Ekwuno <obinnacodes@gmail.com> * reduced target ceiling from 150 gb to 1.5 gb) * Revert "(blog)Draft challenge 10 of 100daysofgatsby (#21969)" This reverts commit 36daee0. Co-authored-by: Hashim Warren <hashimwarren@gmail.com> Co-authored-by: GatsbyJS Bot <mathews.kyle+gatsbybot@gmail.com> Co-authored-by: Obinna Ekwuno <obinnacodes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This challenge completes our 3 week sprint to add SEO, a11y, and performance enhancements to our Gatsby sites.