Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Theme tutorials to Plugin and Theme Tutorials and update redir… #21908

Conversation

Ekwuno
Copy link
Contributor

@Ekwuno Ekwuno commented Mar 2, 2020

…ect links

Description

This PR takes care of the issue opened to Rename Theme tutorials to Plugin and Theme Tutorials and fixes the redirect links.

Documentation

https://www.gatsbyjs.org/tutorial/theme-tutorials/
https://www.gatsbyjs.org/docs/remark-plugin-tutorial/
https://www.gatsbyjs.org/docs/pixabay-source-plugin-tutorial/

Related Issues

#21846

@Ekwuno Ekwuno requested review from marcysutton and gillkyle March 2, 2020 16:17
@Ekwuno Ekwuno requested review from a team as code owners March 2, 2020 16:17
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @Ekwuno! I left some suggestions, let me know if you have any questions.

docs/contributing/docs-contributions.md Outdated Show resolved Hide resolved
docs/docs/gatsby-vendor-partnership.md Outdated Show resolved Hide resolved
docs/docs/naming-a-plugin.md Outdated Show resolved Hide resolved
docs/docs/recipes/sourcing-data.md Outdated Show resolved Hide resolved
docs/docs/schema-gql-type.md Outdated Show resolved Hide resolved
www/redirects.yaml Outdated Show resolved Hide resolved
www/src/data/sidebars/doc-links.yaml Outdated Show resolved Hide resolved
www/src/data/sidebars/doc-links.yaml Outdated Show resolved Hide resolved
www/src/data/sidebars/tutorial-links.yaml Outdated Show resolved Hide resolved
docs/tutorial/theme-tutorials.md Outdated Show resolved Hide resolved
@Ekwuno Ekwuno added the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label Mar 4, 2020
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed some issues with paths for the tutorials, once those are fixed up this should be good to go!

docs/docs/naming-a-plugin.md Outdated Show resolved Hide resolved
docs/docs/gatsby-vendor-partnership.md Outdated Show resolved Hide resolved
docs/docs/recipes/sourcing-data.md Outdated Show resolved Hide resolved
docs/docs/schema-gql-type.md Outdated Show resolved Hide resolved
docs/docs/sourcing-from-private-apis.md Outdated Show resolved Hide resolved
www/redirects.yaml Outdated Show resolved Hide resolved
www/redirects.yaml Outdated Show resolved Hide resolved
www/src/data/sidebars/doc-links.yaml Outdated Show resolved Hide resolved
www/src/data/sidebars/doc-links.yaml Outdated Show resolved Hide resolved
docs/contributing/docs-contributions.md Outdated Show resolved Hide resolved
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an extra space, think that should be the last thing.

docs/tutorial/theme-tutorials.md Outdated Show resolved Hide resolved
@laurieontech
Copy link
Contributor

Looks great @Ekwuno! Let's get this in.

@marcysutton
Copy link
Contributor

Dang, I missed some stuff in this review, particularly the Tutorials landing page. I'm going to submit a PR to get it fixed up quickly, because it's currently incomplete unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants