Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localhost urls/style guide #20956

Closed
wants to merge 6 commits into from

Conversation

bball07
Copy link
Contributor

@bball07 bball07 commented Jan 28, 2020

Description

To be consistent in the Gatsby docs, we want to mark all localhost URL references as code highlighted strings instead of links and document this preference in the Gatsby Style Guide.

Related Issues

Link to related issues (if there are any)
Addresses issue #20756

@marcysutton marcysutton added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Jan 29, 2020
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Brittney, thanks for working on this PR! I left two comments of things that should be updated, and once they're addressed this will be good to go.

docs/contributing/gatsby-style-guide.md Outdated Show resolved Hide resolved
docs/docs/pixabay-source-plugin-tutorial.md Outdated Show resolved Hide resolved
bball07 and others added 2 commits January 29, 2020 20:43
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@bball07
Copy link
Contributor Author

bball07 commented Jan 30, 2020

Thank you Marcy!! I have made those changes :)

@laurieontech laurieontech mentioned this pull request Jan 30, 2020
@laurieontech
Copy link
Contributor

I opened #21047 because it was the only way for me to fix the merge issues for some reason. Sorry about that! Closing this and going to get that merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants