fix(gatsby): Use concrete type resolvers when filtering on node interface fields #16679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will cause quite a conflict with what I'm doing with materialization. I can try porting that so it's based on that. |
This was referenced Aug 21, 2019
|
Superseded by #17284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When filtering on
@nodeInterfacefields, we currently use the resolver on the interface type. This PR changes this to use the resolver on the type returned from the interface'sresolveType, which is in line with what graphql does when resolving the fields in the selection set.Related: #12272 (comment)
Fixes: #16890
Note: I tried to change as little as possible in
prepare-nodeswhich will be replaced by @freiksenet's work in thematerializationbranch anyway.