Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby): use graphiql-explorer #14280
feat(gatsby): use graphiql-explorer #14280
Changes from 19 commits
3c8299d
08f6417
ca9f47c
311485b
f2c10ac
3c02259
a8fc37f
0cae8b2
0e3cd30
ee4c119
866c30f
7688af9
b5c209b
fa07a83
93f4f4d
d57901f
504eb84
cd709e8
0069988
44cbf89
d6502e7
67acb19
0556731
ea49673
b5229d1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple and concise 🤷♂ I think this will suffice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this probably need better package name - this is kind of express middleware, but not exactly, because it's not used as
express.use(someMiddleware())
, instead it is used asgraphiqlExplorer(expressApp, params)
as I need to have 2 route handlers (one for html and one for bundle)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's easy to bike shed here--I don't really have a problem with the name. We could also scope it, e.g.
@gatsbyjs/graphiql
which is really what we've done here. We tweakedgraphiql
with some extra functionality.