-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds more information to documentation pages. #1428
Conversation
Deploy preview ready! Built with commit ac15d9b |
Deploy preview ready! Built with commit ac15d9b |
Deploy preview ready! Built with commit ac15d9b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanups!
packages/gatsby-link/README.md
Outdated
@@ -38,3 +39,17 @@ render () { | |||
</div> | |||
} | |||
``` | |||
|
|||
## Forcing internal redirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The normal term for this is "Programmatic Navigation" — please change this header to that
e.g. https://stackoverflow.com/questions/31079081/programmatically-navigate-using-react-router
docs/docs/path-prefix.md
Outdated
gatsby build --prefix-paths | ||
``` | ||
|
||
NOTE: When using only `build`, Gatsby ignores `pathPrefix`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps re-word this to:
"NOTE: When running the command without the --prefix-paths
flag, Gatsby ignores your pathPrefix
."
Just pushed the changes myself :-) |
import { navigateTo } from "gatsby-link" | ||
|
||
render () { | ||
<div onClick={navigateTo('/example')}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, this code won't run actually though right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it had to be something like this.
I'll submit a small PR for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including:
pathPrefix
navigateTo